KnouandClaude Opus 5
867a07cecb
Close gaps found in a review of the documentation: - Track data/metrics/ and data/metric_sources.json in git so the data checker passes on a fresh clone (finding 23; decision logged) - State the Alaska and Hawaii coverage gap in the README limitations and extend finding 12 - File findings 24-26: the data-sources doc lacks gridMET and several pipeline commands; wettest/driest month are computed twice; solar GHI is written by the extreme-temperature apply step - Add the stale "fallback values" note to filter 2's tasks Tidy the document system: - Add docs/reviews/README.md with the numbering rules and a finding index - Rename koppen-mixed-display-plan.md to koppen-mixed-display.md and fix its stale Puerto Rico and "stage 5" text - Add the precipitation-month step to the README enrichment list - Describe the Current method / Previous method pattern in plan section 5 - Add CLAUDE.md with the project guardrails and doc layout Format filter-calculations.md so it renders on GitHub and in VS Code: inline math uses $...$, ranges use en dashes, and implementation references name functions instead of line numbers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
3.0 KiB
3.0 KiB
Decisions
Open decisions and a dated log of decided ones for the pipeline and the filter-by-filter review. The findings that led to them are in reviews/; the plan they serve is pipeline-plan.md.
Open decisions
| Decision | Options | Needed by |
|---|---|---|
| Committing source summaries | Also commit the source summaries that metric files are built from (for example data/nrel/county_polygon_ghi_summary.csv), or keep them out of git. Metric files are committed; see "Committing metric files" below |
Phase 3 |
| Alaska and Hawaii coverage | Leave blank with a stated coverage gap, or add a source that covers them (for example Daymet or TerraClimate). NOAA nClimGrid and gridMET cover the contiguous U.S. only, so 29 AK and 5 HI counties are blank in filters 2–10; see finding 12 in reviews/00-cross-filter.md | Before Phase 3 |
Decided
- Köppen audit columns (2026-09-12):
koppen.csvstores the top class and share and the runner-up class and share alongsidekoppenZone. - Köppen no-data fallback (2026-09-12): a county with no valid raster cells
is left blank, not assigned
Cfa. - Applying Köppen to the app CSV (2026-09-12): wait until the app supports the Mixed class. Done 2026-09-13.
- Metric files (2026-09-13): one CSV per metric under
data/metrics/, starting withkoppen.csv. - Mixed climate display (2026-09-13): diagonal stripes of each Mixed county's top two classes; see koppen-mixed-display.md.
- Puerto Rico (2026-09-13): off the map and out of every filter. The app already drops state FIPS 72; the data files keep the rows.
- Shared helpers (2026-09-13):
scripts/common/holds only code used by more than one data source, one topic per module; code shared within one data source stays with that source. Duplicates move during their own filter's review. - Annual avg temperature month weighting (2026-09-15): the annual value is the equally weighted mean of the 12 monthly normals, not weighted by month length. This follows WMO-No. 1203 (2017) §4.3.3(a), whose footnote recommends against day-length weighting, and NOAA's 1991–2020 Normals methodology (p. 2). Day weighting would have shifted values by only +0.03 to +0.13 °F. Closes finding 1.
- Annual avg temperature aggregation (2026-09-15): area-weighted county means (sub-cell coverage fraction × cos(latitude)), matching Köppen. Closes finding 2 for this metric.
- Annual avg temperature completeness (2026-09-15): a county is blank unless all 12 monthly values are present (WMO-No. 1203 §4.3.3).
- Annual avg temperature in Alaska and Hawaii (2026-09-15): left blank for now; tracked as the cross-filter "Alaska and Hawaii coverage" open decision.
- Committing metric files (2026-09-15):
data/metrics/anddata/metric_sources.jsonare tracked in git, so the data checker passes on a fresh clone and reproduction tier 2 is possible. Closes finding 23. Whether to also commit source summaries stays open.