KnouandClaude Opus 5
867a07cecb
Close gaps found in a review of the documentation: - Track data/metrics/ and data/metric_sources.json in git so the data checker passes on a fresh clone (finding 23; decision logged) - State the Alaska and Hawaii coverage gap in the README limitations and extend finding 12 - File findings 24-26: the data-sources doc lacks gridMET and several pipeline commands; wettest/driest month are computed twice; solar GHI is written by the extreme-temperature apply step - Add the stale "fallback values" note to filter 2's tasks Tidy the document system: - Add docs/reviews/README.md with the numbering rules and a finding index - Rename koppen-mixed-display-plan.md to koppen-mixed-display.md and fix its stale Puerto Rico and "stage 5" text - Add the precipitation-month step to the README enrichment list - Describe the Current method / Previous method pattern in plan section 5 - Add CLAUDE.md with the project guardrails and doc layout Format filter-calculations.md so it renders on GitHub and in VS Code: inline math uses $...$, ranges use en dashes, and implementation references name functions instead of line numbers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
4.0 KiB
Filter 1: Köppen-Geiger class
Status: Done (2026-09-14): rule applied, Mixed display built, documentation updated.
Data keys: koppenZone, koppenPrimaryClass, koppenSecondaryClass.
Calculation: filter-calculations.md §1. Display
design and history:
koppen-mixed-display.md.
Findings
4. The Köppen fallback can create false data. A county with no valid raster
cells is labeled Cfa instead of missing. A null value plus an audit flag
would distinguish missing coverage from a genuine humid-subtropical class.
Resolved on 2026-09-13: the Köppen builder leaves such counties blank. The
fallback remains only in build_county_climate_data.py, whose Köppen
value is replaced by the apply step.
21. The documented Köppen labels differ from the app. filter-calculations.md
lists the group as "Climate Classification" and the filter as "Köppen-Geiger
Climate Class"; app.js shows "Koppen-Geiger Classification" and
"Koppen-Geiger Climate Class". The app spells Koppen without the umlaut
throughout, while the docs use Köppen. Resolved on 2026-09-15: every
prose and display use of the name now reads "Köppen", in app.js,
README.md, scripts/county_data_sources.md, script docstrings, help text,
and checker messages (with the matching test expectations), and
filter-calculations.md quotes the app's group label, "Köppen-Geiger
Classification". Code identifiers, file names, and data paths such as
koppenZone, normalizeKoppenCode, and koppen_geiger_tif/ keep the ASCII
spelling.
22. The base build's docstring calls its Köppen value a majority class.
build_county_climate_data.py lists koppenZone as the "majority
Koppen-Geiger class", but it assigns the most common class among touched
cells, which need not be a majority. That value is replaced by the Köppen apply
step, and the script is retired in Phase 3. Resolved on 2026-09-15: the
docstring now reads "largest-share Köppen-Geiger class among touched cells
(replaced by the Köppen apply step)".
Cross-filter finding 2 (touched-cell aggregation) was resolved for Köppen on 2026-09-13; see 00-cross-filter.md.
Decisions
In decisions.md: Köppen audit columns, Köppen no-data fallback, and Applying Köppen to the app CSV (2026-09-12); Metric files and Mixed climate display (2026-09-13).
Tasks
Adopted rule: a county is predominantly its top class if and only if that class covers at least 50% of the county's land and leads the runner-up by at least 5 percentage points; otherwise it is Mixed climate. Expected result for the 50 states and DC: 3,010 predominant, 133 Mixed.
- Investigate low-majority counties and adopt the rule.
- Windowed raster reads and 180th-meridian split.
- Area-weighted class shares (16 × 16 sub-cells per raster cell, scaled by
cos(latitude)) in
scripts/common/county_zonal_stats.py. - Apply the 50% / 5-point rule (
scripts/build_county_koppen_metric.py; counties with no valid cells are left blank). - Run the builder to write
data/metrics/koppen.csvand confirm the expected 3,010 predominant / 133 Mixed (2026-09-13). koppenZone-only apply step (scripts/apply_koppen_metric_to_climate_data.py, with--dry-run).- Apply to
data/climate-data.csv(2026-09-13; 142 counties changed to Mixed, withkoppenPrimaryClassandkoppenSecondaryClassadded). - Allow
Mixedincheck_climate_data.py. - Add a Mixed climate category to
app.js, drawn as stripes of the county's top two classes; see koppen-mixed-display.md. - Replace the plurality description in
filter-calculations.md§1 and mark review findings 2 and 4 resolved for Köppen (2026-09-14). - Update the Köppen descriptions and script lists in
README.mdandscripts/county_data_sources.md(2026-09-14). - Tests for shares, the rule, boundary cases, and the apply step
(
tests/test_koppen_metric.py).